Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: using sentinel error for non limited custom resource #565

Merged
merged 1 commit into from
May 16, 2022
Merged

fix: using sentinel error for non limited custom resource #565

merged 1 commit into from
May 16, 2022

Conversation

prometherion
Copy link
Member

Closes #564.

@netlify
Copy link

netlify bot commented May 16, 2022 •
edited
Loading

✅ Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit 806bc76
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/628268fd7f28c90009db405f

alegrey91
alegrey91 reviewed May 16, 2022
View reviewed changes
Copy link
Contributor

@alegrey91 alegrey91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prometherion prometherion merged commit a8b84c8 into master May 16, 2022
@prometherion prometherion deleted the issues/564 branch May 16, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alegrey91 alegrey91 alegrey91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not returning an error in case of non limited custom resource
2 participants
@prometherion @alegrey91