Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dev guide & fix make run issue #437

Merged
merged 4 commits into from
Sep 30, 2021
Merged

Add dev guide & fix make run issue #437

merged 4 commits into from
Sep 30, 2021

Conversation

brightzheng100
Copy link
Contributor

This PR brings in 3 major changes:

  1. Add /docs/dev-guide.md with a complete dev env setup process;
  2. Move /docs/operator/contributing.md to /docs/contributing.md with necessary refactoring because of dev-guide.md;
  3. Fix make run issue in Makefile

prometherion
prometherion requested changes Sep 28, 2021
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvement and a double-check for a possible typo.

prometherion
prometherion approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a review from the master of docs @bsctl would be great, tho.

@prometherion prometherion requested a review from bsctl September 29, 2021 10:04
bsctl
bsctl approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@bsctl bsctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @brightzheng100 thanks

@prometherion prometherion linked an issue Sep 30, 2021 that may be closed by this pull request
Dev env setup issues #429
Closed
@prometherion prometherion merged commit d3e3b8a into projectcapsule:master Sep 30, 2021
@brightzheng100 brightzheng100 deleted the dev-guide branch October 1, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion approved these changes

@bsctl bsctl bsctl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev env setup issues
3 participants
@brightzheng100 @bsctl @prometherion