Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing styling for numerical and A-Z sort buttons to be passed into the FacetFieldPaginationComponent #3492

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

hudajkhan
Copy link
Contributor

@hudajkhan hudajkhan commented Jan 14, 2025

Closes #3491 .
What this PR does:

  • Allows for passing the button-specific styling for the A-Z and numerical sort buttons as a parameter
  • Sets the default classes for styling within the component so _facet_pagination does not need to add a parameter if the default styling is not to be overridden.
  • Uses the styling within the html.erb file

P.S. This component didn't appear to have a direct rspec test before. If that makes sense to add, please let me know. Thanks

Copy link
Contributor

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @hudajkhan !

@sandbergja sandbergja merged commit 67ad400 into main Jan 14, 2025
13 checks passed
@sandbergja sandbergja deleted the paginationclass branch January 14, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling facet field pagination component to accept other styles for the numerical sort and A-Z buttons
2 participants