Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification of Python ChipDevice controller for NFC Commissioning #37141

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

OlivierGre
Copy link
Contributor

Modification of Python ChipDevice controller to be able to launch NFC Commissioning.
pychip_DeviceController_ConnectNFC() will be implemented in another PR. The current PR is needed for the modification of Test Harness environment to add some new NFC commissioning tests. Thanks to this change "nfc-thread"
choice will be accepted by Test Harness interface.
It will help to move forward with the actual implementation of those "nfc-thread" tests.

Testing

I'm not able to test this change. I took the example of BLE interface and I did the same for NFC (without the discriminator parameter).

NFC Commissioning.
pychip_DeviceController_ConnectNFC() will be implemented in another PR.
The current PR is needed for the modification of Test Harness environment
to add some new NFC commissioning tests. Thanks to this change "nfc-thread"
 choice will be accepted by Test Harness interface.
It will help to move forward with the actual implementation of those
 "nfc-thread" tests.
Copy link

semanticdiff-com bot commented Jan 21, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  src/controller/python/ChipDeviceController-ScriptBinding.cpp Unsupported file format
  src/controller/python/chip/ChipDeviceCtrl.py  0% smaller
  src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py Unsupported file format
  src/test_driver/mbed/integration_tests/common/utils.py  0% smaller

@OlivierGre
Copy link
Contributor Author

Restyler is showing lot of modifications not related to my lines. I hope that it will not be annoying for the review...

Copy link

github-actions bot commented Jan 21, 2025

PR #37141: Size comparison from fc76271 to cdca752

Full report (3 builds for cc32xx, stm32)
platform target config section fc76271 cdca752 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538433 538433 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572369 572369 0 0.0
RAM 205320 205320 0 0.0
stm32 light STM32WB5MM-DK FLASH 482648 482648 0 0.0
RAM 144656 144656 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants