CADMIN_1_19.py: Do not try to remove on non commissioned controller (#…

…36989)

The current code is adding a new controller to the fids array which has the effect that the next loop will try to also read from this controller, but the test expects commissioning to fail, so this will not work.

The test currently does not fail because of another problem which is not addressed 8yet) by this PR and is in discussion. To see the effect of this change the used controller need to have more fabrics allowed then the used chip-app - currently because both have same limit of 17 this is failing already on controller instance creation which never added the controller to the fids array.

src/python_testing/TC_CADMIN_1_19.py

@@ -137,8 +137,8 @@ async def test_TC_CADMIN_1_19(self):
         fids_fa_dir[next_fabric] = fids_ca_dir[current_fabrics +
                                                1].NewFabricAdmin(vendorId=0xFFF1, fabricId=next_fabric)
         try:
-            fids[next_fabric] = fids_fa_dir[next_fabric].NewController(nodeId=next_fabric)
-            await fids[next_fabric].CommissionOnNetwork(
+            next_fabric_controller = fids_fa_dir[next_fabric].NewController(nodeId=next_fabric)
+            await next_fabric_controller.CommissionOnNetwork(
                 nodeId=self.dut_node_id, setupPinCode=params.commissioningParameters.setupPinCode,
                 filterType=ChipDeviceCtrl.DiscoveryFilterType.LONG_DISCRIMINATOR, filter=params.randomDiscriminator)