nf() not rounding correctly fixed #5962
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5959
File Changed =
src/utilities/string_functions.js
Problem:
Changes:
roundOffDecPart
modifies thedecPart
but does not truncate it.decPart
is return to thedoNf()
which then truncates thedecPart
according to theright
value.Outcomes of the change:
As mentioned in the issue decription, the improper rounding of the digits of Math.PI is fixed successfully.
Successfully tested it many times at all sorts of possible inputs
PR Checklist
npm run lint
passes