nf() not rounding correctly

[ChristerNilsson]

Most appropriate sub-area of p5.js?

• Accessibility
• Color
• Core/Environment/Rendering
• Data
• DOM
• Events
• Image
• IO
• Math
• Typography
• Utilities
• WebGL
• Build Process
• Unit Testing
• Internalization
• Friendly Errors
• Other (specify if possible)

p5.js version

v1.5.0 October 18, 2022

Web browser and version

Chrome: 109.0.5414.74

Operating System

W10 Home 19045.2486

Steps to reproduce this

console.log(Math.PI)
console.log(nf(Math.PI,1,4))

PI is approx   3.141592653589793
expect answer: 3.1416
actual answer: 3.1415

It seems a simple truncation is used instead of correct rounding.

[akp660]

I want to look into the problem and work on them.

[davepagurek]

Thanks @akp660! I'll assign this to you.

[Qianqianye]

Just link another nf() related issue here #5710: nf() produces problematic string-formatting of very large or small numbers.

[snehilchhabria]

Is this issue resolved already? I may be able to help if no one's working on this.

[Qianqianye]

Is this issue resolved already? I may be able to help if no one's working on this.

Thanks @snehilchhabria for offering help. @aditya-shrivastavv is in the process of resolving it in this pull request #5973.

[snehilchhabria]

okay thanks for your reply.

[owais0017]

hey i want to work on this issue. where do i have to make the changes?

[Qianqianye]

Thanks @owais0017 for offering help. @aditya-shrivastavv is in the process of resolving it in this pull request #5973. Please feel free to take a look at other open issues here. Thank you!

[limzykenneth]

Closed with #5973