Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typos in documentation files #190

Merged
merged 3 commits into from
Jan 2, 2025
Merged

fix: typos in documentation files #190

merged 3 commits into from
Jan 2, 2025

Conversation

vtjl10
Copy link

@vtjl10 vtjl10 commented Dec 22, 2024

Corrected use ::clap::Parser to use clap::Parser

@arnaucube arnaucube changed the base branch from main to typos-aggr December 23, 2024 10:45
@arnaucube
Copy link
Collaborator

hi @vtjl10 , could you fix the rustfmt error? /~https://github.com/privacy-scaling-explorations/sonobe/actions/runs/12455856282/job/34791509958?pr=190

@vtjl10
Copy link
Author

vtjl10 commented Dec 23, 2024

hi @vtjl10 , could you fix the rustfmt error? /~https://github.com/privacy-scaling-explorations/sonobe/actions/runs/12455856282/job/34791509958?pr=190

hi, how can I fix this?

@vtjl10
Copy link
Author

vtjl10 commented Jan 1, 2025

@arnaucube Happy holidays!🙂 Could you check this PR please?

@arnaucube
Copy link
Collaborator

@arnaucube Happy holidays!🙂 Could you check this PR please?

yes, already checked, see the comment: #190 (comment)

Btw, despite hiding all your 'github contribution history' in your github profile page, your contribution history is still public and we can see all your typo-fixing-farming-PRs. In any case, happy to include this PR but please fix the mentioned rustfmt error to proceed.

@vtjl10
Copy link
Author

vtjl10 commented Jan 1, 2025

@arnaucube fixed.

@arnaucube arnaucube merged commit 0ecf5c9 into privacy-scaling-explorations:typos-aggr Jan 2, 2025
9 checks passed
arnaucube pushed a commit that referenced this pull request Jan 12, 2025
@vtjl10 @arnaucube
fix: typos in documentation files (#190)
95e5fbf 
* Update main.rs

* Fix rustfmt errors

---------

Co-authored-by: Игорь <igor@MacBook-Pro.local>
arnaucube pushed a commit that referenced this pull request Jan 22, 2025
@vtjl10 @arnaucube
fix: typos in documentation files (#190)
4430c86 
* Update main.rs

* Fix rustfmt errors

---------

Co-authored-by: Игорь <igor@MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
typos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtjl10 @arnaucube