Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump arkworks to 0.5.0 #179

Merged

Conversation

winderica
Copy link
Collaborator

Now most of the forks listed in #146 are eliminated, although two of them are still inevitable (for now):

ark-circom = { git = "/~https://github.com/winderica/circom-compat", branch = "arkworks-next", default-features = false }
acvm = { git = "/~https://github.com/winderica/noir", branch = "arkworks-next", default-features = false }

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we should maintain this file and noname/bridge.rs in the sonobe repo or in separate repos (e.g. in @dmpierre's forks). I tentatively adopt the former approach but am also happy to change to the latter!

Copy link
Collaborator

@arnaucube arnaucube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Not only migrating to the newer version but also cleaning the trait bounds and the code in general! Very nice!

Regarding the Noir frontend, I think that as you put it it's fine for now, and probably eventually a good move would be to move all the experimental-frontends in a separate repo (one of the reasons being, apart from being highly experimental and slow frontends at their current version, it has been one of the friction/delaying points when advancing the main sonobe crates, due newer versions on the dependencies of the dependencies of the frontends were released, or just by adding extra complexity). For this PR I think it's good as you done it.

@arnaucube arnaucube added this pull request to the merge queue Dec 1, 2024
Merged via the queue into privacy-scaling-explorations:main with commit fa8f821 Dec 1, 2024
9 checks passed
@arnaucube arnaucube mentioned this pull request Dec 17, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants