Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High contrast themes POC #1190

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

High contrast themes POC #1190

wants to merge 1 commit into from

Conversation

langermank
Copy link
Contributor

WIP

Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 8dae79e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Design Token JSON errors:

src/tokens/functional/color/bgColor.json5 (12 errors)

Path Error Code
bgColor.muted.$extensions.org.primer.overrides Unrecognized key: "light-tritanopia-high-contrast", must be one of: light, light-tritanopia, light-protanopia-deuteranopia, light-high-contrast, dark, dark-tritanopia, dark-protanopia-deuteranopia, dark-high-contrast, dark-dimmed unrecognized_keys
bgColor.inset.$extensions.org.primer.overrides Unrecognized key: "light-tritanopia-high-contrast", must be one of: light, light-tritanopia, light-protanopia-deuteranopia, light-high-contrast, dark, dark-tritanopia, dark-protanopia-deuteranopia, dark-high-contrast, dark-dimmed unrecognized_keys
bgColor.disabled.$extensions.org.primer.overrides Unrecognized key: "light-tritanopia-high-contrast", must be one of: light, light-tritanopia, light-protanopia-deuteranopia, light-high-contrast, dark, dark-tritanopia, dark-protanopia-deuteranopia, dark-high-contrast, dark-dimmed unrecognized_keys
bgColor.neutral.muted.$extensions.org.primer.overrides Unrecognized key: "light-tritanopia-high-contrast", must be one of: light, light-tritanopia, light-protanopia-deuteranopia, light-high-contrast, dark, dark-tritanopia, dark-protanopia-deuteranopia, dark-high-contrast, dark-dimmed unrecognized_keys
bgColor.neutral.emphasis.$extensions.org.primer.overrides Unrecognized key: "light-tritanopia-high-contrast", must be one of: light, light-tritanopia, light-protanopia-deuteranopia, light-high-contrast, dark, dark-tritanopia, dark-protanopia-deuteranopia, dark-high-contrast, dark-dimmed unrecognized_keys
bgColor.success.muted.$extensions.org.primer.overrides Unrecognized key: "light-tritanopia-high-contrast", must be one of: light, light-tritanopia, light-protanopia-deuteranopia, light-high-contrast, dark, dark-tritanopia, dark-protanopia-deuteranopia, dark-high-contrast, dark-dimmed unrecognized_keys
bgColor.open.muted.$extensions.org.primer.overrides Unrecognized key: "light-tritanopia-high-contrast", must be one of: light, light-tritanopia, light-protanopia-deuteranopia, light-high-contrast, dark, dark-tritanopia, dark-protanopia-deuteranopia, dark-high-contrast, dark-dimmed unrecognized_keys
bgColor.open.emphasis.$extensions.org.primer.overrides Unrecognized key: "light-tritanopia-high-contrast", must be one of: light, light-tritanopia, light-protanopia-deuteranopia, light-high-contrast, dark, dark-tritanopia, dark-protanopia-deuteranopia, dark-high-contrast, dark-dimmed unrecognized_keys
bgColor.severe.muted.$extensions.org.primer.overrides Unrecognized key: "light-tritanopia-high-contrast", must be one of: light, light-tritanopia, light-protanopia-deuteranopia, light-high-contrast, dark, dark-tritanopia, dark-protanopia-deuteranopia, dark-high-contrast, dark-dimmed unrecognized_keys
bgColor.severe.emphasis.$extensions.org.primer.overrides Unrecognized key: "light-tritanopia-high-contrast", must be one of: light, light-tritanopia, light-protanopia-deuteranopia, light-high-contrast, dark, dark-tritanopia, dark-protanopia-deuteranopia, dark-high-contrast, dark-dimmed unrecognized_keys
bgColor.closed.muted.$extensions.org.primer.overrides Unrecognized key: "light-tritanopia-high-contrast", must be one of: light, light-tritanopia, light-protanopia-deuteranopia, light-high-contrast, dark, dark-tritanopia, dark-protanopia-deuteranopia, dark-high-contrast, dark-dimmed unrecognized_keys
bgColor.closed.emphasis.$extensions.org.primer.overrides Unrecognized key: "light-tritanopia-high-contrast", must be one of: light, light-tritanopia, light-protanopia-deuteranopia, light-high-contrast, dark, dark-tritanopia, dark-protanopia-deuteranopia, dark-high-contrast, dark-dimmed unrecognized_keys

Copy link
Contributor

Design Token Diff (CSS)

/css/functional/themes/light-high-contrast.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/light-high-contrast.css	2025-02-27 01:57:44.604199463 +0000
@@ -38,7 +38,7 @@
 --bgColor-severe-muted: #fff2d5;
 --bgColor-sponsors-emphasis: #971368;
 --bgColor-sponsors-muted: #feeff7;
-  --bgColor-success-emphasis: #055d20;
+  --bgColor-success-emphasis: #0349b4;
 --bgColor-success-muted: #d2fedb;
 --bgColor-transparent: #ffffff00;
 --borderColor-accent-emphasis: #0349b4;
@@ -662,7 +662,7 @@
   --bgColor-severe-muted: #fff2d5;
   --bgColor-sponsors-emphasis: #971368;
   --bgColor-sponsors-muted: #feeff7;
-    --bgColor-success-emphasis: #055d20;
+    --bgColor-success-emphasis: #0349b4;
   --bgColor-success-muted: #d2fedb;
   --bgColor-transparent: #ffffff00;
   --borderColor-accent-emphasis: #0349b4;

Copy link
Contributor

Design Token Diff (StyleLint)

The message is too long to be displayed here. For more details, please check the job summary.

Copy link
Contributor

Design Token Diff (Figma)

/figma/figma.json

+++ /home/runner/work/primitives/primitives/dist/figma/figma.json	2025-02-27 01:58:02.539202038 +0000
@@ -75,7 +75,8 @@
       "light protanopia deuteranopia",
       "dark protanopia deuteranopia",
       "light tritanopia",
-        "dark tritanopia"
+        "dark tritanopia",
+        "light tritanopia high contrast"
     ],
     "groups": [
       "shadow",
@@ -117,6 +118,7 @@
   "dist/figma/themes/dark.json",
   "dist/figma/themes/light-colorblind.json",
   "dist/figma/themes/light-high-contrast.json",
+    "dist/figma/themes/light-tritanopia-high-contrast.json",
   "dist/figma/themes/light-tritanopia.json",
   "dist/figma/themes/light.json",
   "dist/figma/typography/typography.json"

/figma/themes/light-high-contrast.json

+++ /home/runner/work/primitives/primitives/dist/figma/themes/light-high-contrast.json	2025-02-27 01:57:57.987202225 +0000
@@ -5962,14 +5962,14 @@
 {
   "name": "bgColor/success-emphasis",
   "value": {
-      "r": 0.0196078431372549,
-      "g": 0.36470588235294116,
-      "b": 0.12549019607843137,
+      "r": 0.011764705882352941,
+      "g": 0.28627450980392155,
+      "b": 0.7058823529411765,
     "a": 1
   },
   "type": "COLOR",
   "refId": "mode/bgColor/success-emphasis",
-    "reference": "base/color/light-high-contrast/base/color/green/5",
+    "reference": "base/color/light-high-contrast/base/color/blue/5",
   "collection": "mode",
   "mode": "light high contrast",
   "group": "semantic",
@@ -6000,9 +6000,9 @@
 {
   "name": "bgColor/open-emphasis",
   "value": {
-      "r": 0.0196078431372549,
-      "g": 0.36470588235294116,
-      "b": 0.12549019607843137,
+      "r": 0.011764705882352941,
+      "g": 0.28627450980392155,
+      "b": 0.7058823529411765,
     "a": 1
   },
   "type": "COLOR",

@github-actions github-actions bot temporarily deployed to Preview (Storybook) February 27, 2025 01:59 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant