fix: #15885, InputNumberModule: Variant filled is not applied #16013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
cetincakiroglu
requested changes
Jul 18, 2024
| @@ -98,6 +98,7 @@ export const INPUTNUMBER_VALUE_ACCESSOR: any = { | |||
| [attr.data-pc-section]="'input'" | |||
| pAutoFocus | |||
| [autofocus]="autofocus" | |||
| [class.p-variant-filled]="variant == 'filled'" | |||
There was a problem hiding this comment.
In here, could you please also check the inputStyle signal in config? As an example, you can check autocomplete component:
cetincakiroglu
added
the
Resolution: Needs Revision
|
Hi, To make the process faster and include the fix for this issue to the 17.18.5 release today. We've fixed the issue in: #16060 Thanks a lot for the effort and support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
fix: #15885, InputNumberModule: Variant filled is not applied