-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make format compatible with "PER Coding Style 2.0" #2269
feat: make format compatible with "PER Coding Style 2.0" #2269
Conversation
Hi @czosel can you take a look a this PR? |
I want to make this change, I look at the PRs and I realise that I'm 5 days late... Thanks @ferchoz ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ferchoz, thanks for contributing and sorry about the delay! The idea looks good to me, just a minor point for completeness.
Improved! |
@czosel can you take a look at it? thanks!! |
b8128f5
to
9fe6fd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for contributing @ferchoz
Released in |
This change allows to use this plugin along with "PER Coding Style 2.0"
formating :
readonly final class ClassName {}
to
final readonly class ClassName {}
doc:
https://www.php-fig.org/per/coding-style/#46-modifier-keywords