Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): Shuffle packages and tidy up #619

Merged
merged 3 commits into from
Oct 25, 2023
Merged

feat(experimental): Shuffle packages and tidy up #619

merged 3 commits into from
Oct 25, 2023

Conversation

mfridman
Copy link
Collaborator

This PR is mechanical and basic cleanups, with one fix for out-of-order migrations.

It adds a lot more tests to the core implementation. Once satisfies we'll move this into the top-level goose package, and also expose the global SetGlobalGoMigrations and ResetGlobalGoMigrations.

┌─────────────────────────────────────────────────────────────────────────────────────────────────┐
│  STATUS │ ELAPSED │                    PACKAGE                    │ COVER │ PASS │ FAIL │ SKIP  │
│─────────┼─────────┼───────────────────────────────────────────────┼───────┼──────┼──────┼───────│
│  PASS   │  1.79s  │ github.com/pressly/goose/v3/internal/provider │ 82.7% │  60  │  0   │  1    │
└─────────────────────────────────────────────────────────────────────────────────────────────────┘

Version int64
Source string // path to .sql script or go file
Registered bool
UseTx bool
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this. Instead, we calculate this based on the functions.

I think a limitation with the old system is the inability to set an up (with tx) and a down (without a tx). We should be able to support different up / down combinations.

@mfridman mfridman merged commit a9da750 into master Oct 25, 2023
9 checks passed
@mfridman mfridman deleted the gh-379-5 branch October 25, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant