-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix longstanding bug in replace #32
Conversation
For several years, replace has not worked in normal mode. This commit fixes that bug. In addition, I've updated the tests and README a bit. At this point, all existing tests are passing. There's a clean slate for new changes or CI.
I just setup Vader in CI twice in the last two days, if you like I can probably whip it out easily while it's fresh in my mind. |
That would be terrific! If it's okay with you, I may add/remove/rework (Btw, I don't seem to be authorized to merge the pull request. Please |
Sure, should be just a few minutes. For now I won't setup a way to run it locally (you seem to have that figured out anyway) but will add CI checks to make sure they are run remotely before future merges.
Can you try again? I just fiddled with permissions, it may not have been setup right. It would be nice to get that straightened out. |
Yes, I can now merge (and I have). Thanks. |
In the future, I should probably handle the merge commit better. |
For the record, some tests were failing until I merged this work into my CI branch, now they all pass. So you did something right ;-) |
For several years, replace has not worked in normal mode. This commit
fixes that bug. In addition, I've updated the tests and README a bit.
At this point, all existing tests are passing. There's a clean slate for
new changes or CI.
(The bug was added in #19. In the end, the fix was trivial, but it took
me too long to see it. I'd like to set up CI now, so I'll start in on that
branch after this is merged. I'd also like to update the test files to be
more sandboxed from the user's larger vim environment.)