Merge pull request #445 from preactjs/v11-skip-signal-tests

preactjs · Nov 21, 2022 · c84f304 · c84f304
2 parents c5a43a0 + ea1360d
commit c84f304
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/test-e2e/tests/filter-text-signal.test.ts b/test-e2e/tests/filter-text-signal.test.ts
@@ -2,6 +2,10 @@ import { expect, test } from "@playwright/test";
 import { gotoTest } from "../pw-utils";
 
 test("Text Signal filter should filter Text Signal nodes", async ({ page }) => {
+	test.skip(
+		process.env.PREACT_VERSION !== "10",
+		"Signals are not supported in v11 yet.",
+	);
 	const { devtools } = await gotoTest(page, "signals-text");
 
 	await devtools

diff --git a/test-e2e/tests/inspect-signal.test.ts b/test-e2e/tests/inspect-signal.test.ts
@@ -2,6 +2,10 @@ import { test, expect } from "@playwright/test";
 import { gotoTest, locateTreeItem } from "../pw-utils";
 
 test("Show signal in props and update value", async ({ page }) => {
+	test.skip(
+		process.env.PREACT_VERSION !== "10",
+		"Signals are not supported in v11 yet.",
+	);
 	const { devtools } = await gotoTest(page, "signals");
 
 	await devtools.locator(locateTreeItem("Display")).first().click();
@@ -74,6 +78,10 @@ test("Show signals in hooks", async ({ page }) => {
 });
 
 test("Dectect signal subscriptions", async ({ page }) => {
+	test.skip(
+		process.env.PREACT_VERSION !== "10",
+		"Signals are not supported in v11 yet.",
+	);
 	const { devtools } = await gotoTest(page, "signals-subscribe");
 
 	await devtools.click(locateTreeItem("App"));