Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not throw exception #59

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix not throw exception #59

wants to merge 2 commits into from

Conversation

EtienneLt
Copy link
Contributor

@EtienneLt EtienneLt commented Jan 16, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt self-assigned this Jan 16, 2025
@etiennehomer etiennehomer changed the title fix a swallowed exception S3 mode : add "tar" to ARCHIVE_FORMATS Jan 16, 2025
@etiennehomer etiennehomer self-requested a review January 16, 2025 17:03
@EtienneLt EtienneLt closed this Jan 17, 2025
@EtienneLt EtienneLt reopened this Jan 17, 2025
@EtienneLt EtienneLt changed the title S3 mode : add "tar" to ARCHIVE_FORMATS Fix not throw exception Jan 17, 2025
@@ -63,7 +63,7 @@ public class S3CaseService implements CaseService {
private static final Logger LOGGER = LoggerFactory.getLogger(S3CaseService.class);
public static final int MAX_SIZE = 500000000;
public static final List<String> COMPRESSION_FORMATS = List.of("bz2", "gz", "xz", "zst");
public static final List<String> ARCHIVE_FORMATS = List.of("zip");
public static final List<String> ARCHIVE_FORMATS = List.of("zip", "tar");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove it is in another pr

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants