-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not throw exception #59
Open
EtienneLt
wants to merge
2
commits into
main
Choose a base branch
from
fix-swallowed-exception
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
etiennehomer
changed the title
fix a swallowed exception
S3 mode : add "tar" to ARCHIVE_FORMATS
Jan 16, 2025
etiennehomer
approved these changes
Jan 16, 2025
EtienneLt
changed the title
S3 mode : add "tar" to ARCHIVE_FORMATS
Fix not throw exception
Jan 17, 2025
EtienneLt
commented
Jan 17, 2025
@@ -63,7 +63,7 @@ public class S3CaseService implements CaseService { | |||
private static final Logger LOGGER = LoggerFactory.getLogger(S3CaseService.class); | |||
public static final int MAX_SIZE = 500000000; | |||
public static final List<String> COMPRESSION_FORMATS = List.of("bz2", "gz", "xz", "zst"); | |||
public static final List<String> ARCHIVE_FORMATS = List.of("zip"); | |||
public static final List<String> ARCHIVE_FORMATS = List.of("zip", "tar"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to remove it is in another pr
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: