fix: Add context errors as allowed direct comparisons (#63)

polyfloyd · Dec 5, 2023 · 2175ff4 · 2175ff4
1 parent 679f044
commit 2175ff4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/errorlint/allowed.go b/errorlint/allowed.go
@@ -71,6 +71,9 @@ var allowedErrors = []struct {
 	{err: "io.EOF", fun: "(*strings.Reader).ReadAt"},
 	{err: "io.EOF", fun: "(*strings.Reader).ReadByte"},
 	{err: "io.EOF", fun: "(*strings.Reader).ReadRune"},
+	// pkg/context
+	{err: "context.DeadlineExceeded", fun: "(context.Context).Err"},
+	{err: "context.Canceled", fun: "(context.Context).Err"},
 }
 
 var allowedErrorWildcards = []struct {

diff --git a/errorlint/testdata/src/allowed/allowed.go b/errorlint/testdata/src/allowed/allowed.go
@@ -3,6 +3,7 @@ package testdata
 import (
 	"archive/tar"
 	"bytes"
+	"context"
 	"database/sql"
 	"debug/elf"
 	"errors"
@@ -227,3 +228,13 @@ func CompareUnixErrors() {
 		fmt.Println(err)
 	}
 }
+
+func ContextErr(ctx context.Context) error {
+	if err := ctx.Err(); err == context.DeadlineExceeded {
+		return err
+	}
+	if err := ctx.Err(); err == context.Canceled {
+		return err
+	}
+	return nil
+}