-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridges patch applied for stable2409 #519
Merged
fellowship-merge-bot
merged 20 commits into
polkadot-fellows:main
from
bkontur:bko-bridges-patch
Jan 16, 2025
Merged
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c6e1480
Update patched deps for Bridges TODOs
bkontur 5240e81
More updates
bkontur 01a1d2c
Fixed/removed TODO for bridges
bkontur 8ce2796
Update from bkontur running command 'fmt'
actions-user 601970b
WIP: Fix bridges integration tests
bkontur ccdb9e6
Update from bkontur running command 'fmt'
actions-user 1cefb53
Fix bridges integration tests
bkontur c046dd8
Move bridges testing data to XCMv4
bkontur 92c1279
Merge remote-tracking branch 'polkadot-fellows/main' into bko-bridges…
bkontur ae408e3
Nit
bkontur cbdfc72
Updated weights for pallet-xcm-bridge-hub-router
bkontur ecad255
Set `force_xcm_version` for receive message proof, because we have st…
bkontur cddfbd3
Adjust fresh weights and consts
bkontur cc9763e
Apply suggestions from code review
bkontur c84c364
Last nit
bkontur c6dade6
Removed unused consts
bkontur b89597c
Merge branch 'main' into bko-bridges-patch
bkontur b8ac4c6
Merge branch 'main' into bko-bridges-patch
bkontur 658d621
Merge remote-tracking branch 'polkadot-fellows/main' into bko-bridges…
bkontur 313d0dc
Merge branch 'main' into bko-bridges-patch
bkontur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When will these tests be integrated into CI? :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! I think the main issue is the
sudo
tweaking mentioned in paritytech/parity-bridges-common#3016, but it should be solvable. Additionally, there are open issues for adding Chopsticks support.I created a tracking issue for this: #544.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sudo can just be worked around by doing on chain proposal and fast track it with a fake fellowship :D For sure a little bit more complicated, but doable with chopsticks.