use parquet.ByteArrayValue instead of ValueOf (#594)

This should reduce allocations from any to []byte
polarsignals · Nov 22, 2023 · dcf20c4 · dcf20c4
1 parent 066ad2b
commit dcf20c4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pqarrow/parquet.go b/pqarrow/parquet.go
@@ -115,7 +115,7 @@ func recordToRows(
 					if k != start {
 						rep = 1
 					}
-					scratchRows[i] = append(scratchRows[i], parquet.ValueOf(v).Level(rep, def+1, j))
+					scratchRows[i] = append(scratchRows[i], parquet.ByteArrayValue(v).Level(rep, def+1, j))
 				}
 			}
 		default:
@@ -134,7 +134,7 @@ func recordToRows(
 					vidx := arr.GetValueIndex(indexIntoRecord)
 					switch dict := arr.Dictionary().(type) {
 					case *array.Binary:
-						scratchRows[i] = append(scratchRows[i], parquet.ValueOf(dict.Value(vidx)).Level(0, def, j))
+						scratchRows[i] = append(scratchRows[i], parquet.ByteArrayValue(dict.Value(vidx)).Level(0, def, j))
 					default:
 						scratchRows[i] = append(scratchRows[i], parquet.ValueOf(dict.GetOneForMarshal(vidx)).Level(0, def, j))
 					}