fix: Subtraction with underflow on empty FixedSizeBinaryArray #20109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to deserialize an arrow IPC stream with a fixed-size binary array that contains no values, the code currently subtracts with underflow. In the Python package (which uses a release build), this is silently ignored as debug assertions are turned off. Instead, you get a panic about an out-of-bounds offset.
PanicException: assertion failed: self.check_bound(offset)
By checking for an underflow, everything works fine.
To reproduce the issue, you can try the following code: