Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix the lower bound when converting numbers less than 0 to unsigned integers #8544

Merged
merged 24 commits into from
Jan 10, 2019
Merged

*: fix the lower bound when converting numbers less than 0 to unsigned integers #8544

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
4cd33a2
types: fix the lower bound when converting numbers less than 0 to uns…
exialin Dec 2, 2018
d234d34
fix test and consider other cases
exialin Dec 8, 2018
73c227b
Merge branch 'master' into fix-insert
exialin Dec 8, 2018
78f4953
Merge branch 'master' into fix-insert
exialin Dec 10, 2018
8805474
address review
exialin Dec 10, 2018
f002c79
remove commented lines
exialin Dec 10, 2018
96be6e2
Merge branch 'master' into fix-insert
exialin Dec 10, 2018
769e8b8
Merge branch 'master' into fix-insert
exialin Dec 12, 2018
ffdf1bf
Merge branch 'master' into fix-insert
exialin Dec 14, 2018
6781530
Merge branch 'master' into fix-insert
exialin Dec 15, 2018
3de142c
Merge branch 'master' into fix-insert
exialin Jan 4, 2019
37fb967
add test for load data
exialin Jan 4, 2019
4b5ebaa
minor change
exialin Jan 5, 2019
92d87de
fix
exialin Jan 5, 2019
c94c9f3
fix
exialin Jan 7, 2019
1071091
Merge branch 'master' into fix-insert
exialin Jan 7, 2019
cb06953
add sc
exialin Jan 7, 2019
b95cc14
Merge branch 'master' into fix-insert
exialin Jan 8, 2019
8eff853
Merge branch 'master' into fix-insert
winoros Jan 9, 2019
62c79e8
fix ci
exialin Jan 9, 2019
60f2e3b
remove update
exialin Jan 9, 2019
e62b14a
rename function
exialin Jan 10, 2019
e1141b3
Merge remote-tracking branch 'upstream/master' into fix-insert
exialin Jan 10, 2019
e716837
Merge branch 'master' into fix-insert
zz-jason Jan 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove update
  • Loading branch information
@exialin
exialin committed Jan 9, 2019
commit 60f2e3bcf9614b4a482c1c110f3389f4ace4e5f8
2 changes: 1 addition & 1 deletion sessionctx/stmtctx/stmtctx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ func (sc *StatementContext) GetExecDetails() execdetails.ExecDetails {
func (sc *StatementContext) ShouldClipToZero() bool {
// TODO: Currently altering column of integer to unsigned integer is not supported.
// If it is supported one day, that case should be added here.
return sc.InInsertStmt || sc.InUpdateStmt || sc.InLoadDataStmt
return sc.InInsertStmt || sc.InLoadDataStmt
}

// ShouldIgnoreError indicates whether we should ignore the error when type conversion overflows,
Expand Down