Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: improve UT coverage of expression package to 80% (#10641) #11620

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Aug 5, 2019

What problem does this PR solve?

cherry-pick #10641 to release 2.1

#11479 need cherry-pick to release-2.1 ,and it is dependent on this pr.

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Aug 5, 2019

Add more description for why do we need this commit?

@wshwsh12 wshwsh12 requested a review from XuHuaiyu August 5, 2019 11:59
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Aug 5, 2019

@XuHuaiyu @zz-jason PTAL

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 22feb85 into pingcap:release-2.1 Aug 5, 2019
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. type/2.1 cherry-pick labels Aug 5, 2019
@wshwsh12 wshwsh12 deleted the release-2.1 branch August 5, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants