Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: ignore the virtual column when collect statistics (#10623) #10629

Merged
merged 2 commits into from
May 29, 2019
Merged

planner: ignore the virtual column when collect statistics (#10623) #10629

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c03f51
planner: ignore the virtual column when collect statistics (#10623)
lonng May 29, 2019
3fc9770
Merge branch 'release-3.0' into cherry-pick-10623-release-3.0
winkyao May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
planner: ignore the virtual column when collect statistics (#10623) 
Signed-off-by: Lonng <heng@lonng.org>
  • Loading branch information
@lonng
lonng committed May 29, 2019
commit 2c03f51cbe21e13ffb95dfb93d09c8708b2a9dea
4 changes: 4 additions & 0 deletions planner/core/planbuilder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,10 @@ func (b *PlanBuilder) buildCheckIndexSchema(tn *ast.TableName, indexName string)
func getColsInfo(tn *ast.TableName) (indicesInfo []*model.IndexInfo, colsInfo []*model.ColumnInfo, pkCol *model.ColumnInfo) {
tbl := tn.TableInfo
for _, col := range tbl.Columns {
// The virtual column will not store any data in TiKV, so it should be ignored when collect statistics
if col.IsGenerated() && !col.GeneratedStored {
continue
}
if tbl.PKIsHandle && mysql.HasPriKeyFlag(col.Flag) {
pkCol = col
} else {
Expand Down