This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
checker: allow to ignore some checking items #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IANTHEREAL
added
priority/normal
|
/run-all-tests |
csuzhangxc
reviewed
Mar 6, 2019
| } | ||
| delete(checkingItems, AllChecking) | ||
|
|
||
| c.Assert(FilterCheckingItems(ignoredCheckingItems[:0]), DeepEquals, checkingItems) |
There was a problem hiding this comment.
Suggested change
| c.Assert(FilterCheckingItems(ignoredCheckingItems[:0]), DeepEquals, checkingItems) | |
| c.Assert(FilterCheckingItems(nil), DeepEquals, checkingItems) |
more readable?
|
@july2993 PTAL |
july2993
reviewed
Mar 6, 2019
| return nil | ||
| } | ||
|
|
||
| checkingItems := config.FilterCheckingItems(cfgs[0].IgnoreCheckingItems) |
There was a problem hiding this comment.
unclear why just get from index 0
|
@july2993 @csuzhangxc PTAL again |
july2993
approved these changes
Mar 7, 2019
csuzhangxc
added
status/LGT2
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
allow to ignore some checking items
What is changed and how it works?
add a
IgnoreCheckingItemsconfiguration, and use it to filter checking items incheckerCheck List
Tests
Code changes