Fix for pelias/api#1077

[Joxit]

Fail to search Saint.. cities in structured queries

Add synonym for saint and sainte

[orangejulius]

Hi @Joxit.
I think this looks good. It's honestly been a while since we've touched this code, and it's quite tricky to ensure synonyms don't have unexpected side effects, especially with autocomplete. However, because this only affects admin area analysers, which we will likely stop using soon for autocomplete (to be replaced by much improved admin area support from Placeholder), I doubt there are any possible problems. I even went so far as to find a case where an address exists in St Louis and other cities:

/v1/autocomplete?text=1443 park ave, saint louis

I tried all the combinations of abbreviations I could think of. The bad news is we already don't do a great job unless the city name is fully specified, the good news is that means we probably can't break it further :)

I'd love for @missinglink to chime in on this and pelias/api#1077 but it looks good to me!

[Joxit]

Any news on this? This will be outdated with #272

(Up to date with master now)

[missinglink]

Hi @Joxit, you caught us in a time of transition!

I just cleaned up the synonyms, standardizing them to the solr file format (and putting them in their own files) in #272.

In #273 I added the ability for users to add their own custom synonyms. (today I added support for 'admin' as well as for 'name' and 'street').

I opened #274 today to address this issue, it adds your synonyms to the synonyms/custom_admin.txt file and I added a couple more too. I also changed them to be synonyms instead of substitutions (using a comma instead of =>).

Let me know what you think?
Sorry, I wasn't able to rebase your commits, the history was getting too crazy!

tl;dr I added this commit custom_synonyms...custom_synonyms_admin

[Joxit]

Hi @missinglink, Yeah I saw your refactoring 😉

It looks good to me. Nice job, I saw that you added fort and mount too.

The next step will be to clean pelias-api/sanitizer/_city_name_standardizer.js that's it ? (to keep only whitespace_normalized)

[orangejulius]

@Joxit I agree. I think pelias/api#767 which added that custom and america-centric handling of mt/st/fort can be replaced with some of the alias work we're doing and proper updates to data in WOF

[trescube]

The city name standardize stuff should go away, it's a relic of a time when we flirted with the idea of pulling analysis out of ES and into code.

[orangejulius]

Hey, it solved some problems. And I think we may still pull more analysis out to make it replicable elsewhere.

[Joxit]

@orangejulius this is a good idea.

[missinglink]

changes merged in #274, thanks for your contribution!

[Joxit]

Yeah! Nice, you are welcome ;-)