-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for "square" Cooler files #225
Conversation
On a second thought, there are many operations on "square" Cooler files that work out of the box: basically everything except So the right thing to do is to support opening "square" Cooler files, and throw an exception when one of the unsupported This would also be a good time to introduce appropriate checks in the hictk CLI:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
- Coverage 74.59% 74.37% -0.23%
==========================================
Files 144 144
Lines 12058 12090 +32
Branches 1384 1384
==========================================
- Hits 8995 8992 -3
- Misses 1945 1978 +33
- Partials 1118 1120 +2 ☔ View full report in Codecov by Sentry. |
…etric-upper" This reverts commit 326e7bd.
Superseded by #249. |
No description provided.