Merge pull request #335 from paulsengroup/fix/unit-test

[bug]: fix mis-tagged unit tests
paulsengroup · Feb 23, 2025 · 8e39fde · 8e39fde
2 parents 7bbb2f1 + 9206016
commit 8e39fde
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/libhictk/binary_buffer/include/hictk/impl/binary_buffer_impl.hpp b/src/libhictk/binary_buffer/include/hictk/impl/binary_buffer_impl.hpp
@@ -42,7 +42,7 @@ inline void BinaryBuffer::read(std::string &buff, std::size_t n) {
 inline void BinaryBuffer::read(char *buff, std::size_t n) {
   static_assert(sizeof(char) == 1);
   const auto size = n * sizeof(char);
-  assert(_i + size < _buffer.size());
+  assert(_i + size <= _buffer.size());
   // NOLINTNEXTLINE(*-pointer-arithmetic)
   std::memcpy(static_cast<void *>(buff), _buffer.data() + _i, size);
   _i += size;

diff --git a/test/units/binary_buffer/binary_buffer_test.cpp b/test/units/binary_buffer/binary_buffer_test.cpp
@@ -9,7 +9,7 @@
 namespace hictk::binary_buffer::test {
 
 // NOLINTBEGIN(*-avoid-magic-numbers, readability-function-cognitive-complexity)
-TEST_CASE("BinaryBuffer") {
+TEST_CASE("BinaryBuffer", "[binarybuffer][short]") {
   const std::vector<std::uint32_t> ibuff{1, 2, 3};
   // NOLINTNEXTLINE
   const std::string sibuff{reinterpret_cast<const char*>(ibuff.data()),

diff --git a/test/units/hic/file_zoomify_test.cpp b/test/units/hic/file_zoomify_test.cpp
@@ -23,7 +23,7 @@ namespace hictk::hic::test::file_writer {
 
 using namespace hictk::hic::internal;
 
-TEST_CASE("HiC: HiCFileZoomify") {
+TEST_CASE("HiC: HiCFileZoomify", "[hic][v9][zoomify][long]") {
   const std::vector<std::uint32_t> resolutions{100'000, 400'000, 1'000'000};
 
   const auto path1 = (datadir / "4DNFIZ1ZVXC8.hic9").string();