Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix infinite loop during parameter estimation (#40)
Hello @himoto! I hope this finds you well. While reproducing the results in this repository, we found that the code gets stuck in an infinite loop during [the parameter estimation step](https://pasmopy.github.io/breast_cancer/getting-started/individualization.html). More specifically, it was failing to generate the initial values for the parameters, causing the code to retry indefinitely. After some investigation, I think I have pinned down the cause of this problem to the line that checked the exit status of the simulation: `is_successful = ifelse(sol.retcode === :Success, true, false)` Changing the comparison operator to a *looser* `==` fixed the problem. It's a very subtle change, but I thought I'd push this in case anyone else wants to reproduce the results. Co-authored-by: Hiroaki Imoto <hiroaki.imoto@ucd.ie>
- Loading branch information