Fix build & advisory issues. #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpschorr
force-pushed
the
chore-update-tests
branch
from
9f097f6 to
4c68744
Compare
jpschorr
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
==========================================
+ Coverage 80.69% 80.74% +0.05%
==========================================
Files 80 80
Lines 19405 19405
Branches 19405 19405
==========================================
+ Hits 15658 15669 +11
+ Misses 3322 3311 -11
Partials 425 425 ☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5562 Number failing in both: 833 Number passing in Base (a7993de) but now fail: 2 Number failing in Base (a7993de) but now pass: 0 Click here to see
|
jpschorr
force-pushed
the
chore-update-tests
branch
from
aa7e0c2 to
23f5103
Compare
jpschorr
changed the title
alancai98
approved these changes
Dec 4, 2024
| @@ -170,7 +170,7 @@ pub struct BasicContext<'a> { | |||
| pub errors: RefCell<Vec<EvaluationError>>, | |||
| } | |||
|
|
|||
| impl<'a> BasicContext<'a> { | |||
| impl BasicContext<'_> { | |||
There was a problem hiding this comment.
seems unrelated to your change but there's a clippy warning on L149:
unexpected `cfg` condition value: `serde`
warning: unexpected `cfg` condition value: `serde`
--> partiql-eval/src/eval/mod.rs:149:12
|
149 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
| ^^^^^^^^^^^^^^^^^ help: remove the condition
|
= note: no expected values for `feature`
= help: consider adding `serde` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
derivativewitheduce. #518 (see below)Fix the following as reported by
cargo deny checkCf. mcarton/rust-derivative#117
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.