Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused deps #1119

Merged
merged 4 commits into from
Jan 23, 2025
Merged

chore: remove unused deps #1119

merged 4 commits into from
Jan 23, 2025

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 19, 2025 •
edited
Loading

Fixes #XXXX.

Description

mime, prost, prost-build, bzip2, xz2, thread-priority, hashlru, maplit are unused.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 19, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12880893459

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 12.714%
Totals Coverage Status
Change from base Build 12873819985: 0.0%
Covered Lines: 2459
Relevant Lines: 19341
💛 - Coveralls

@de-sh de-sh requested a review from nitisht January 21, 2025 05:48
@nitisht nitisht merged commit 02e2007 into parseablehq:main Jan 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitisht nitisht nitisht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@de-sh @coveralls @nitisht