Fix frame-benchmarking-cli
not buildable without rocksdb
#7263
+30
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
frame-benchmarking-cli
crate has not been buildable without therocksdb
feature since version 1.17.0.Error:
This issue is also related to the
rocksdb
feature bleeding (#3793), where therocksdb
feature was always activated even when compiling this crate with--no-default-features
.Fix:
paritydb
as the default database when compiled without therocksdb
feature.sc-cli
crate'srocksdb
feature was always active, even compilingframe-benchmarking-cli
with--no-default-features
.Review Notes
Fix the crate to be built without rocksdb, not intended to solve #3793.