Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frame-benchmarking-cli not buildable without rocksdb #7263

Open
wants to merge 2 commits into from

Conversation

bgallois
Copy link
Contributor

Description

The frame-benchmarking-cli crate has not been buildable without the rocksdb feature since version 1.17.0.

Error:

self.database()?.unwrap_or(Database::RocksDb),
                             ^^^^^^^ variant or associated item not found in `Database`

This issue is also related to the rocksdb feature bleeding (#3793), where the rocksdb feature was always activated even when compiling this crate with --no-default-features.

Fix:

  • Resolved the error by choosing paritydb as the default database when compiled without the rocksdb feature.
  • Fixed the issue where the sc-cli crate's rocksdb feature was always active, even compiling frame-benchmarking-cli with --no-default-features.

Review Notes

Fix the crate to be built without rocksdb, not intended to solve #3793.

@bkchr bkchr requested review from skunert and ggwpez January 20, 2025 16:28
@bkchr bkchr added the T0-node This PR/Issue is related to the topic “node”. label Jan 20, 2025
@bkchr
Copy link
Member

bkchr commented Jan 20, 2025

/cmd prdoc --audience runtime_dev --bump patch

@bkchr bkchr enabled auto-merge January 20, 2025 20:16
@bkchr bkchr added this pull request to the merge queue Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants