Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: Ignore target folder for main repo #1151

Closed
wants to merge 1 commit into from
Closed

git: Ignore target folder for main repo #1151

wants to merge 1 commit into from

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Aug 25, 2023

Ignore build artifacts generated by running cargo build --release

@lexnv
git: Ignore target folder for main repo
9873548 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added A0-please_review R0-silent Changes should not be mentioned in any release notes labels Aug 25, 2023
@lexnv lexnv self-assigned this Aug 25, 2023
@lexnv lexnv requested review from alvicsam and liamaharon August 25, 2023 10:34
@ordian
Copy link
Member

ordian commented Aug 25, 2023 •
edited
Loading

This is being fixed in #1145: /~https://github.com/paritytech/polkadot-sdk/pull/1145/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947

ggwpez
ggwpez requested changes Aug 25, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dont yet merge stuff into master, the monorepo migration is not complete yet.
We are using as-ci branch as intermediary #1145

@lexnv
Copy link
Contributor Author

lexnv commented Aug 25, 2023

We could close this in favor of #1145, thanks for letting me know and handling this!

@lexnv lexnv closed this Aug 25, 2023
@ordian ordian deleted the lexnv/git-ignore branch August 26, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez requested changes

@liamaharon liamaharon liamaharon approved these changes

@alvicsam alvicsam Awaiting requested review from alvicsam

Assignees

@lexnv lexnv

Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lexnv @ordian @ggwpez @liamaharon @the-right-joyce