add <image> as a valid element type to bundle in <svg> tags (w/ tests) (

#2113)
parcel-bundler · Oct 6, 2018 · f8aa228 · f8aa228
1 parent 1afb3e8
commit f8aa228
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 1 deletion.
diff --git a/packages/core/parcel/src/assets/HTMLAsset.js b/packages/core/parcel/src/assets/HTMLAsset.js
@@ -22,7 +22,7 @@ const ATTRS = {
   href: ['link', 'a', 'use'],
   srcset: ['img', 'source'],
   poster: ['video'],
-  'xlink:href': ['use'],
+  'xlink:href': ['use', 'image'],
   content: ['meta'],
   data: ['object']
 };

diff --git a/packages/core/parcel/test/html.js b/packages/core/parcel/test/html.js
@@ -608,6 +608,23 @@ describe('html', function() {
     });
   });
 
+  it('should bundle svg files using <image xlink:href=""> correctly', async function() {
+    let b = await bundle(
+      path.join(__dirname, '/integration/html-svg-image/index.html')
+    );
+
+    await assertBundleTree(b, {
+      name: 'index.html',
+      assets: ['index.html'],
+      childBundles: [
+        {
+          type: 'svg',
+          assets: ['file.svg']
+        }
+      ]
+    });
+  });
+
   it('should support data attribute of object element', async function() {
     let b = await bundle(
       path.join(__dirname, '/integration/html-object/index.html')

diff --git a/packages/core/parcel/test/integration/html-svg-image/file.svg b/packages/core/parcel/test/integration/html-svg-image/file.svg
diff --git a/packages/core/parcel/test/integration/html-svg-image/index.html b/packages/core/parcel/test/integration/html-svg-image/index.html
@@ -0,0 +1,4 @@
+<!DOCTYPE html>
+<svg xmlns:xlink="http://www.w3.org/1999/xlink">
+	<image xlink:href="file.svg"/>
+</svg>