Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#686: Move Subscription management functions to separate class #819

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

supereddie
Copy link
Contributor

Part 03 of refactoring the ServiceBusHelper class #686. This is a fairly straight-forward 'move code to different class' to simplify the changes.

This part is moving Subscription 'management actions' - that is, actions for Subscriptions that need the Microsoft.ServiceBus.NamespaceManager to work.

In addition:

  • Add a general OnCreated() method because some Subscription events use a custom type SubscriptionWrapper for ServiceBusHelperEventArgs.EntityInstance, which in turn is used in various UI Controls

Copy link
Collaborator

@ErikMogensen ErikMogensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@ErikMogensen ErikMogensen merged commit 76a118e into paolosalvatori:main Jan 7, 2025
2 checks passed
@supereddie supereddie deleted the features/refactor-03 branch January 7, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants