Implement issue 802 #815
Merged
Implement issue 802 #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaorisKong
requested review from
paolosalvatori,
SeanFeldman and
ErikMogensen
as code owners
SeanFeldman
reviewed
Dec 3, 2024
ErikMogensen
reviewed
Dec 3, 2024
| @@ -1817,6 +1817,7 @@ private void RefreshIndividualSubscription(SubscriptionDescription subscriptionD | |||
| private void RefreshIndividualTopic(TreeNode selectedNode) | |||
| { | |||
| var wasTopicNodeExpanded = selectedNode.IsExpanded; | |||
| var wasSubscriptionsNodeExpaned = false; | |||
There was a problem hiding this comment.
A minor spelling error: wasSubscriptionsNodeExpaned -> wasSubscriptionsNodeExpanded
Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #802
just implement the feature when refresh the topic node.
not sure is it necessary to implement at other mode(Queues, Eventhhubs), as their Treeview structure was different.
not keep subscription node and rule node expaned, as it will add some ugly compare code in Foreach cycle and in daily use I just want keep subscriptions node expaned.