Turn nailgun initialization message down to debug #21865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the intention with these log lines is logging expensive operations. However, the
NailgunPool::new
operation itself isn't expensive, and so doesn't need to be logged (sometimes twice) on every start-up.As a fairly-expert Pants user, I'm not sure what information one should get from knowing that there's potentially 16 processes managed by nailgun, and other less-expert users likely have even less use for it!
Fixes #21863 , revisits #20946 (comment) (particularly the last paragraph).