Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn nailgun initialization message down to debug #21865

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Jan 22, 2025

I think the intention with these log lines is logging expensive operations. However, the NailgunPool::new operation itself isn't expensive, and so doesn't need to be logged (sometimes twice) on every start-up.

As a fairly-expert Pants user, I'm not sure what information one should get from knowing that there's potentially 16 processes managed by nailgun, and other less-expert users likely have even less use for it!

Fixes #21863 , revisits #20946 (comment) (particularly the last paragraph).

@huonw huonw added the release-notes:not-required PR doesn't require mention in release notes label Jan 22, 2025
@huonw huonw marked this pull request as ready for review January 22, 2025 03:09
@huonw huonw requested review from kaos, benjyw and alonsodomin January 22, 2025 03:11
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is good, since those messages give the impression that the nailgun startup is expensive, but actually it's the solver that is taking the time that those messages seem to be hanging on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting pants shows useless "Initializing Nailgun pool ..." log lines
2 participants