Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-2005] fix structured data #1308

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[DEV-2005] fix structured data #1308

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b9d69b7
fix structured data in tutorial page
MarBert Jan 16, 2025
06a7448
add default name if seo is missing
MarBert Jan 17, 2025
6d6b8e3
add changeset
MarBert Jan 17, 2025
4051e70
Update .changeset/unlucky-garlics-peel.md
MarBert Jan 17, 2025
191e8d8
Update apps/nextjs-website/src/app/case-histories/[caseHistorySlug]/p…
MarBert Jan 17, 2025
bec1d91
merge with main
MarBert Jan 20, 2025
119641c
Merge branch 'DEV-2005-fix-structured-data' of github.com:pagopa/deve…
MarBert Jan 20, 2025
bc2e247
Merge branch 'main' into DEV-2005-fix-structured-data
marcobottaro Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-garlics-peel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"nextjs-website": minor
---

Fix empty metadata field in listitems
MarBert marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion apps/nextjs-website/src/app/[productSlug]/api/[apiDataSlug]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const ApiDataPage = async ({ params }: ApiDataParams) => {
breadcrumbsItems: [
productToBreadcrumb(apiDataProps?.product),
{
name: apiDataProps?.seo?.metaTitle,
name: apiDataProps?.seo?.metaTitle || apiDataProps?.title,
item: breadcrumbItemByProduct(product, [
'api',
`${apiDataProps?.apiDataSlug}`,
Expand Down
4 changes: 3 additions & 1 deletion apps/nextjs-website/src/app/[productSlug]/api/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ const ApiDataListPage = async ({ params }: { params: Params }) => {
breadcrumbsItems: [
productToBreadcrumb(apiDataListPageProps?.product),
{
name: apiDataListPageProps?.seo?.metaTitle,
name:
apiDataListPageProps?.seo?.metaTitle ||
apiDataListPageProps?.hero.title,
item: breadcrumbItemByProduct(apiDataListPageProps?.product, ['api']),
},
],
Expand Down
2 changes: 1 addition & 1 deletion apps/nextjs-website/src/app/[productSlug]/guides/[...productGuidePage]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ const Page = async ({ params }: { params: Params }) => {
breadcrumbsItems: [
productToBreadcrumb(product),
{
name: seo?.metaTitle,
name: seo?.metaTitle || page.title,
item: breadcrumbItemByProduct(product, [
'guides',
...(params?.productGuidePage || []),
Expand Down
2 changes: 1 addition & 1 deletion apps/nextjs-website/src/app/[productSlug]/guides/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const GuideListPage = async ({ params }: ProductParams) => {
breadcrumbsItems: [
productToBreadcrumb(product),
{
name: seo?.metaTitle,
name: seo?.metaTitle || abstract?.title,
item: breadcrumbItemByProduct(product, ['guides']),
},
],
Expand Down
3 changes: 2 additions & 1 deletion apps/nextjs-website/src/app/[productSlug]/quick-start/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
breadcrumbItemByProduct,
productToBreadcrumb,
} from '@/helpers/structuredData.helpers';
import { title } from 'process';

export async function generateStaticParams() {
return [...getProductsSlugs('quickStart')].map((productSlug) => ({
Expand Down Expand Up @@ -73,7 +74,7 @@ const QuickStartGuidesPage = async ({ params }: ProductParams) => {
breadcrumbsItems: [
productToBreadcrumb(product),
{
name: seo?.metaTitle,
name: seo?.metaTitle || abstract?.title,
item: breadcrumbItemByProduct(product, ['quick-start']),
},
],
Expand Down
3 changes: 2 additions & 1 deletion apps/nextjs-website/src/app/[productSlug]/tutorials/[...productTutorialPage]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import {
productToBreadcrumb,
} from '@/helpers/structuredData.helpers';
import { getUrlReplaceMapProps } from '@/lib/cmsApi';
import { title } from 'process';

type Params = {
productSlug: string;
Expand Down Expand Up @@ -99,7 +100,7 @@ const Page = async ({ params }: { params: Params }) => {
breadcrumbsItems: [
productToBreadcrumb(strapiTutorialProps.product),
{
name: strapiTutorialProps.seo?.metaTitle,
name: strapiTutorialProps.seo?.metaTitle || strapiTutorialProps.title,
item: breadcrumbItemByProduct(strapiTutorialProps.product, [
'guides',
...(params?.productTutorialPage || []),
Expand Down
2 changes: 1 addition & 1 deletion apps/nextjs-website/src/app/[productSlug]/tutorials/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const TutorialsPage = async ({ params }: ProductParams) => {
breadcrumbsItems: [
productToBreadcrumb(product),
{
name: seo?.metaTitle,
name: seo?.metaTitle || abstract?.title,
item: breadcrumbItemByProduct(product, ['tutorials']),
},
],
Expand Down
2 changes: 1 addition & 1 deletion apps/nextjs-website/src/app/case-histories/[caseHistorySlug]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const Page = async ({ params }: { params: Params }) => {
const structuredData = generateStructuredDataScripts({
breadcrumbsItems: [
{
name: caseHistory.seo?.metaTitle,
name: caseHistory.seo?.metaTitle || params.caseHistorySlug,
MarBert marked this conversation as resolved.
Show resolved Hide resolved
item: getItemFromPaths(['case-histories', caseHistory.slug]),
},
],
Expand Down
Loading