-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAI-252] Chatbot/deploy workflow #1231
Conversation
|
Branch is not up to date with base branch@batdevis it seems this Pull Request is not updated with base branch. |
Jira Pull Request LinkThis Pull Request refers to the following Jira issue CAI-252 |
- name: Update ImageTag in task-definition | ||
id: task-def | ||
uses: aws-actions/amazon-ecs-render-task-definition@4225e0b507142a2e432b018bc3ccb728559b437a # v1.2.0 | ||
with: | ||
task-definition: apps/chatbot/task-definition.json | ||
container-name: chatbot-docker | ||
image: ${{ steps.login-ecr.outputs.registry }}/chatbot:${{ github.sha }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is only necessary when deploying to ECS. In this case where we use Lambda, a task definition is not needed
- name: Update ImageTag in task-definition | |
id: task-def | |
uses: aws-actions/amazon-ecs-render-task-definition@4225e0b507142a2e432b018bc3ccb728559b437a # v1.2.0 | |
with: | |
task-definition: apps/chatbot/task-definition.json | |
container-name: chatbot-docker | |
image: ${{ steps.login-ecr.outputs.registry }}/chatbot:${{ github.sha }} |
- name: Deploy new ECS task definition | ||
uses: aws-actions/amazon-ecs-deploy-task-definition@df9643053eda01f169e64a0e60233aacca83799a # v1.4.11 | ||
with: | ||
task-definition: ${{ steps.task-def.outputs.task-definition }} | ||
service: chatbot-ecs | ||
cluster: chatbot-ecs-cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
- name: Deploy new ECS task definition | |
uses: aws-actions/amazon-ecs-deploy-task-definition@df9643053eda01f169e64a0e60233aacca83799a # v1.4.11 | |
with: | |
task-definition: ${{ steps.task-def.outputs.task-definition }} | |
service: chatbot-ecs | |
cluster: chatbot-ecs-cluster |
- name: Generate task-definition file | ||
run: aws ecs describe-task-definition --task-definition chatbot-task-def --query taskDefinition > task-definition.json | ||
|
||
- name: Update ImageTag in task-definition | ||
id: task-def | ||
uses: aws-actions/amazon-ecs-render-task-definition@4225e0b507142a2e432b018bc3ccb728559b437a # v1.2.0 | ||
with: | ||
task-definition: apps/chatbot/task-definition.json | ||
container-name: chatbot-docker | ||
image: ${{ steps.login-ecr.outputs.registry }}/chatbot:${{ github.sha }} | ||
|
||
- name: Deploy new ECS task definition | ||
uses: aws-actions/amazon-ecs-deploy-task-definition@df9643053eda01f169e64a0e60233aacca83799a # v1.4.11 | ||
with: | ||
task-definition: ${{ steps.task-def.outputs.task-definition }} | ||
service: chatbot-ecs | ||
cluster: chatbot-ecs-cluster | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
- name: Generate task-definition file | |
run: aws ecs describe-task-definition --task-definition chatbot-task-def --query taskDefinition > task-definition.json | |
- name: Update ImageTag in task-definition | |
id: task-def | |
uses: aws-actions/amazon-ecs-render-task-definition@4225e0b507142a2e432b018bc3ccb728559b437a # v1.2.0 | |
with: | |
task-definition: apps/chatbot/task-definition.json | |
container-name: chatbot-docker | |
image: ${{ steps.login-ecr.outputs.registry }}/chatbot:${{ github.sha }} | |
- name: Deploy new ECS task definition | |
uses: aws-actions/amazon-ecs-deploy-task-definition@df9643053eda01f169e64a0e60233aacca83799a # v1.4.11 | |
with: | |
task-definition: ${{ steps.task-def.outputs.task-definition }} | |
service: chatbot-ecs | |
cluster: chatbot-ecs-cluster | |
This pull request is stale because it has been open for 14 days with no activity. If the pull request is still valid, please update it within 21 days to keep it open or merge it, otherwise it will be closed automatically. |
This pull request was closed because it has been inactive for 21 days since being marked as stale. |
List of Changes
Deploy workflow of Chatbot backend
Motivation and Context
We need a pipeline to deploy the lambda function.