Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary file lists from Tofino CMake. #5039

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Nov 30, 2024

These files are already covered by the scan in cmake/Linters.cmake

Also enable linting for Tofino and P4Testgen.

@fruffy fruffy added infrastructure Topics related to code style and build and test infrastructure. tofino Topics related to the Tofino switch and back end. labels Nov 30, 2024
…r Tofino and P4Testgen.

Signed-off-by: fruffy <fruffy@nyu.edu>
@fruffy fruffy force-pushed the fruffy/tofino_cpplint branch from 2719c9f to f9709ca Compare November 30, 2024 21:04
@fruffy fruffy marked this pull request as ready for review December 1, 2024 14:41
@fruffy fruffy requested review from ChrisDodd, pkotikal and hanw December 1, 2024 14:41
@fruffy fruffy added this pull request to the merge queue Dec 9, 2024
@ChrisDodd
Copy link
Contributor

Just a note -- how are you getting this past the CI failures seen in #5054?

@fruffy
Copy link
Collaborator Author

fruffy commented Dec 9, 2024

Just a note -- how are you getting this past the CI failures seen in #5054?

This was an older PR which already passed before the failures, let's whether it will get past the merge queue..

Merged via the queue into main with commit 9d97cb5 Dec 9, 2024
20 checks passed
@fruffy fruffy deleted the fruffy/tofino_cpplint branch December 9, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Topics related to code style and build and test infrastructure. tofino Topics related to the Tofino switch and back end.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants