Skip to content

Commit

Permalink
Remove unused files from testdata
Browse files Browse the repository at this point in the history
All of the files removed by this commit appear never to be used during
p4c test runs.  Some details about each removed file and why it is
still in the repository are given below.

+ p4_14_samples_outputs/wide_action2-midend.p4

The other files with names beginning "wide_action2" were removed with
this commit in 2019.  It appears that the one remaining one was not
removed then, as it should have been.

commit ae6fb22
Author: Mihai Budiu <mbudiu@vmware.com>
Date:   Thu Apr 25 16:46:31 2019 -0700

+ p4_16_dpdk_errors_outputs/pna-dpdk-large-constants.p4-error
+ p4_16_dpdk_errors_outputs/pna-dpdk-large-constants.p4.bfrt.json

Other files with a similar name were modifed, or moved from directory
p4_16_dpdk_errors_outputs to directory p4_16_samples_output, with this
commit.  The two files above appear to have been forgotten to be
removed.

commit 4005380 (HEAD -> main, origin/main, origin/
HEAD)
Author: maheswari-s <maheswari.subramanian@intel.com>
Date:   Mon Dec 23 22:41:14 2024 +0530

+ p4_16_errors/constructor3_e.s

It was first added in this commit:

commit 6b9da23
Author: Mihai Budiu <mbudiu@vmware.com>
Date:   Mon Nov 23 11:58:14 2020 -0800

which appears to have been a mistake.

+ p4tc_samples_outputs/default_action_example_parser.o

This is an ELF format binary file, which appears to have been
committed by accident in this commit.

commit 9005729
Author: Komal Jain <komal.jain@intel.com>
Date:   Wed Nov 29 16:34:20 2023 +0530

+ p4_16_errors_outputs/issue1777-bmv2.p4.entries.txt
+ p4_16_errors_outputs/issue1803_same_table_name.p4.entries.txt
+ p4_16_errors_outputs/issue-2123_e.p4.entries.txt
+ p4_16_errors_outputs/issue2283_2-bmv2.p4.entries.txt
+ p4_16_errors_outputs/issue3299.p4.entries.txt
+ p4_16_errors_outputs/issue532.p4.entries.txt
+ p4_16_errors_outputs/table-entries-lpm-2.p4.entries.txt
+ p4_16_errors_outputs/table-entries-optional-2-bmv2.p4.entries.txt
+ p4_16_samples_outputs/fabric_20190420/fabric.p4.entries.txt
+ p4_16_samples_outputs/omec/up4.p4.entries.txt
+ p4_16_samples_outputs/pins/pins_fabric.p4.entries.txt
+ p4_16_samples_outputs/pins/pins_middleblock.p4.entries.txt
+ p4_16_samples_outputs/pins/pins_wbb.p4.entries.txt

All of the files above have another file in the repo with a file name
suffix of `.txtpb`, and the commit below that added many other
`.txtpb` files and removed the corresponding `.txt` files neglected to
remove the files above.

commit 5082fe3
Author: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Date:   Wed Jan 24 18:31:00 2024 +0100

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
  • Loading branch information
jafingerhut committed Dec 31, 2024
1 parent 4005380 commit 3287117
Show file tree
Hide file tree
Showing 18 changed files with 0 additions and 535 deletions.
124 changes: 0 additions & 124 deletions testdata/p4_14_samples_outputs/wide_action2-midend.p4

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion testdata/p4_16_errors/constructor3_e.s

This file was deleted.

2 changes: 0 additions & 2 deletions testdata/p4_16_errors_outputs/issue-2123_e.p4.entries.txt

This file was deleted.

2 changes: 0 additions & 2 deletions testdata/p4_16_errors_outputs/issue1777-bmv2.p4.entries.txt

This file was deleted.

This file was deleted.

2 changes: 0 additions & 2 deletions testdata/p4_16_errors_outputs/issue2283_2-bmv2.p4.entries.txt

This file was deleted.

2 changes: 0 additions & 2 deletions testdata/p4_16_errors_outputs/issue3299.p4.entries.txt

This file was deleted.

2 changes: 0 additions & 2 deletions testdata/p4_16_errors_outputs/issue532.p4.entries.txt

This file was deleted.

Loading

0 comments on commit 3287117

Please sign in to comment.