Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Switch grapher exports to use CF worker #4464

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Jan 17, 2025

Resolves #4093 and #3661

Supersedes #3746 and #4099

Changes

  • Switches all references to /exports/ to use our dynamic thumbnails instead
    • Except the mockSiteRouter view in /admin/charts
  • Removes code that baked graphers to /exports/
    • Some charts in country profiles will no longer load in the NoJS version of the site because their slugs have updated but formatWordpressPost isn't checking redirects. We could:
      1. Fix this in the code
      2. Update the country profile templates
      3. Not fix it
  • In all thumbnail imgs where applicable, switches the image extension from .svg to .png, to ensure webfonts always show correctly.

Caveats

  • NoJS country profile pages are still a bit broken, as they don't have the correct entity selected, nor do they take redirects into account

@owidbot
Copy link
Contributor

owidbot commented Jan 17, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-remove-grapher-exports

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-17 21:59:54 UTC
Execution time: 1.18 seconds

@ikesau
Copy link
Member Author

ikesau commented Jan 17, 2025

This is blocked by #4450

So I'm going to work on that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webfonts aren't loading correctly in Grapher SVG thumbnails
2 participants