Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite tests #163

Merged
merged 4 commits into from
Nov 10, 2021
Merged

rewrite tests #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35df508
rewrite tests
figsoda Nov 4, 2021
253cedc
crate dir-diff -> fn assert_same_directory
figsoda Nov 4, 2021
2b9023e
misc comments and wording changes
figsoda Nov 4, 2021
c4a71d8
add information about tests to CONTRIBUTING.md
figsoda Nov 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@ makeshift_testing.py

# These are backup files generated by rustfmt
**/*.rs.bk

# crash logs generated by proptest
*.proptest-regressions
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ Feel free to open an issue anytime you wish to ask a question, suggest a feature

1. Be nice to other people.
2. If editing the Rust source code, remember to run `rustfmt` (otherwise, CI will warn you the code was not properly formatted).
3. If new formats are added, please add the format to `tests/integration.rs`.
If it is an archive format that handles directories, it should be added to `DirectoryExtension`, otherwise it should be added to `FileExtension`.
It should be added to `mime.rs` as well if the [`infer`](https://docs.rs/infer) crate supports it.
Most tests are written with `proptest` ([book](https://altsysrq.github.io/proptest-book/), [docs](https://docs.rs/proptest)).
If you wish to improve these tests, the proptest book might help you.

Note: we are using `unstable` features of `rustfmt`! Nightly toolchain is required (will likely be installed automatically, cause the toolchain was specified in the project root).

Expand Down
Loading