Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(advisors): Do not explicitly depend on testUtils #9986

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

sschuberth
Copy link
Member

This is already done globally via test suite conventions 1 (in order to always have kotest.properties on the test classpath).

This is already done globally via test suite conventions [1] (in order
to always have `kotest.properties` on the test classpath).

[1]: /~https://github.com/oss-review-toolkit/ort/blob/cd855bef34c68613d1b33601130678b39ce912e3/buildSrc/src/main/kotlin/ort-kotlin-conventions.gradle.kts#L61

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
@sschuberth sschuberth requested a review from a team as a code owner February 28, 2025 13:07
@sschuberth sschuberth enabled auto-merge (rebase) February 28, 2025 13:07
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.40%. Comparing base (73f3a58) to head (cdca339).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9986   +/-   ##
=========================================
  Coverage     68.40%   68.40%           
  Complexity     1420     1420           
=========================================
  Files           265      265           
  Lines          9300     9300           
  Branches        983      983           
=========================================
  Hits           6362     6362           
  Misses         2494     2494           
  Partials        444      444           
Flag Coverage Δ
funTest-non-docker 33.36% <ø> (ø)
test-ubuntu-24.04 36.93% <ø> (ø)
test-windows-2022 36.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth sschuberth disabled auto-merge February 28, 2025 14:22
@sschuberth
Copy link
Member Author

Merging despite the unrelated test failures.

@sschuberth sschuberth merged commit 5162e66 into main Feb 28, 2025
25 of 26 checks passed
@sschuberth sschuberth deleted the adv-no-text-utils-dep branch February 28, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants