Show appropriate dialog titles for Navigation Actions

osmandapp · Mar 2, 2025 · a80be41 · a80be41
1 parent 39911e3
commit a80be41
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 1 deletion.
diff --git a/OsmAnd/src/net/osmand/plus/quickaction/actions/NavAddDestinationAction.java b/OsmAnd/src/net/osmand/plus/quickaction/actions/NavAddDestinationAction.java
@@ -39,6 +39,12 @@ protected Object getLocationIcon(@NonNull MapActivity mapActivity) {
 		return mapActivity.getMapLayers().getNavigationLayer().getPointToNavigateIcon();
 	}
 
+	@NonNull
+	@Override
+	protected String getDialogTitle(@NonNull Context context) {
+		return context.getString(R.string.add_destination_point);
+	}
+
 	@NonNull
 	@Override
 	protected CharSequence getQuickActionDescription(@NonNull Context context) {

diff --git a/OsmAnd/src/net/osmand/plus/quickaction/actions/NavAddFirstIntermediateAction.java b/OsmAnd/src/net/osmand/plus/quickaction/actions/NavAddFirstIntermediateAction.java
@@ -39,6 +39,12 @@ protected Object getLocationIcon(@NonNull MapActivity mapActivity) {
 		return mapActivity.getMapLayers().getNavigationLayer().getIntermediatePointIcon();
 	}
 
+	@NonNull
+	@Override
+	protected String getDialogTitle(@NonNull Context context) {
+		return context.getString(R.string.add_intermediate_point);
+	}
+
 	@NonNull
 	@Override
 	protected CharSequence getQuickActionDescription(@NonNull Context context) {

diff --git a/OsmAnd/src/net/osmand/plus/quickaction/actions/NavDirectionsFromAction.java b/OsmAnd/src/net/osmand/plus/quickaction/actions/NavDirectionsFromAction.java
@@ -39,6 +39,12 @@ protected Object getLocationIcon(@NonNull MapActivity mapActivity) {
 		return mapActivity.getMapLayers().getNavigationLayer().getStartPointIcon();
 	}
 
+	@NonNull
+	@Override
+	protected String getDialogTitle(@NonNull Context context) {
+		return context.getString(R.string.add_start_point);
+	}
+
 	@NonNull
 	@Override
 	protected CharSequence getQuickActionDescription(@NonNull Context context) {

diff --git a/OsmAnd/src/net/osmand/plus/quickaction/actions/NavReplaceDestinationAction.java b/OsmAnd/src/net/osmand/plus/quickaction/actions/NavReplaceDestinationAction.java
@@ -39,6 +39,12 @@ protected Object getLocationIcon(@NonNull MapActivity mapActivity) {
 		return mapActivity.getMapLayers().getNavigationLayer().getPointToNavigateIcon();
 	}
 
+	@NonNull
+	@Override
+	protected String getDialogTitle(@NonNull Context context) {
+		return context.getString(R.string.add_destination_point);
+	}
+
 	@NonNull
 	@Override
 	protected CharSequence getQuickActionDescription(@NonNull Context context) {

diff --git a/OsmAnd/src/net/osmand/plus/quickaction/actions/SelectMapLocationAction.java b/OsmAnd/src/net/osmand/plus/quickaction/actions/SelectMapLocationAction.java
@@ -67,7 +67,7 @@ public void onLocationSelected(@NonNull LatLon latLon) {
 			@NonNull
 			@Override
 			public String getDialogTitle() {
-				return mapActivity.getString(R.string.choose_location);
+				return SelectMapLocationAction.this.getDialogTitle(mapActivity);
 			}
 		};
 	}
@@ -77,6 +77,11 @@ public String getDialogTitle() {
 	@Nullable
 	protected abstract Object getLocationIcon(@NonNull MapActivity mapActivity);
 
+	@NonNull
+	protected String getDialogTitle(@NonNull Context context) {
+		return context.getString(R.string.choose_location);
+	}
+
 	public boolean isManualLocationSelection() {
 		return Boolean.parseBoolean(getParameter(KEY_SELECT_LOCATION_MANUALLY, "true"));
 	}