-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/loading screen #43
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please stick to the established conventions. Why would we pollute the main typescript file with all of this markdown, this makes this file near impossible to read and understand
packages/core/src/index.ts
Outdated
@@ -10,7 +11,121 @@ function initializeVerification(config: OrbaOneConfig, button: ReturnType<typeof | |||
|
|||
//Set Loading state | |||
button.setState("loading"); | |||
loadingDiv.innerHTML = ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ridiculous, why are cluttering the main index file with all of this markdown?!
8bc4f79
to
c8bb2d7
Compare
Example of how loading screen looks when the user clicks the rendered button