Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scope action only has pull when get service token in executing cmd org push #1600

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

hopegi
Copy link
Contributor

@hopegi hopegi commented Dec 27, 2024

What this PR does / why we need it:
fix scope action only has pull when get service token in executing cmd org push

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1599
fix this issue #1599

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

fix scope action only has pull when get service token in executing cmd `org push`

Signed-off-by: hopegi <690383065@qq.com>
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (9eece43) to head (e7bc5aa).
Report is 1 commits behind head on release-1.2.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.2    #1600   +/-   ##
============================================
  Coverage        82.95%   82.95%           
============================================
  Files              107      107           
  Lines             4652     4652           
============================================
  Hits              3859     3859           
  Misses             564      564           
  Partials           229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT shizhMSFT added the question Further information is requested label Dec 30, 2024
@Wwwsylvia
Copy link
Member

@hopegi Thank you for the PR! Could you update the PR title to include a fix: prefix followed by the PR purpose?

@hopegi hopegi changed the title Update push.go fix: scope action only has pull when get service token in executing cmd org push Jan 13, 2025
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TerryHowe TerryHowe merged commit b36e543 into oras-project:release-1.2 Jan 15, 2025
8 checks passed
Wwwsylvia pushed a commit to Wwwsylvia/oras that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants