-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: scope action only has pull when get service token in executing cmd org push #1600
Conversation
fix scope action only has pull when get service token in executing cmd `org push` Signed-off-by: hopegi <690383065@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #1600 +/- ##
============================================
Coverage 82.95% 82.95%
============================================
Files 107 107
Lines 4652 4652
============================================
Hits 3859 3859
Misses 564 564
Partials 229 229 ☔ View full report in Codecov by Sentry. |
@hopegi Thank you for the PR! Could you update the PR title to include a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…md org push (oras-project#1600) Signed-off-by: hopegi <690383065@qq.com>
What this PR does / why we need it:
fix scope action only has pull when get service token in executing cmd
org push
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1599
fix this issue #1599
Please check the following list: