Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3602 Make checks before error is thrown clear #3603

Closed
wants to merge 1 commit into from

Conversation

GavinRay97
Copy link
Contributor

No information/reason is currently provided so you have no idea what is going on unless you grep the codebase.
NOTE: GRAAL_HOME is marked for deprecation in the code by v22.0.0, so unsure if this should be visibly included or not.

No information/reason is currently provided so you have no idea what is going on unless you grep the codebase.
NOTE: `GRAAL_HOME` is marked for deprecation in the code by `v22.0.0`, so unsure if this should be visibly included or not.
@graalvmbot
Copy link
Collaborator

Hello GavinRay97, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address ray -(dot)- gavin97 -(at)- gmail -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@GavinRay97
Copy link
Contributor Author

Contributor agreement signed =)

@GavinRay97
Copy link
Contributor Author

Bot pls check the OCA again, it's been confirmed

@GavinRay97
Copy link
Contributor Author

This bot is not very good:

image

image

=/

@munishchouhan
Copy link
Contributor

@GavinRay97 your OCA is not approved yet, once its approved, Bot will add the label

@GavinRay97
Copy link
Contributor Author

@GavinRay97 your OCA is not approved yet, once its approved, Bot will add the label

It was approved 5 days ago though, that is why I added a screenshot with the approval in my inbox and the date of the email in that comment 🤔

If the number following the name of the document is the ID number, then my number is 4904

image

image

image

@munishchouhan
Copy link
Contributor

munishchouhan commented Jul 28, 2021

@GavinRay97 thanks for the clarification
I will check with the OCA team.

@graalvmbot
Copy link
Collaborator

GavinRay97 has signed the Oracle Contributor Agreement (based on email address ray -(dot)- gavin97 -(at)- gmail -(dot)- com) so can contribute to this repository.

@fniephaus
Copy link
Member

Hey @GavinRay97, thanks for the PR. GRAALVM_HOME is also not really used anymore, unless you use our Native Build Tools. More importantly, GraalVM for JDK 17 and later no longer ship gu (#6855). I hope you don't mind if I close this PR now because we will soon remove the old gu sources from this repository.

@fniephaus fniephaus closed this Jan 22, 2024
@fniephaus fniephaus assigned fniephaus and unassigned Ondrej-Douda Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gu breaks on 21.3.0-dev when installing manually using sdkman (likely symlink issue)
5 participants