fix: trino metadata performance issues
#3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jabolol
temporarily deployed
to
external-prs-app
GitHub Actions
Inactive
![oso-prs[bot]](/~https://avatars.githubusercontent.com/in/856587?s=60&v=4){kind=small}
|
/test-deploy 1ee1457 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the way in which we generate metadata to make it more performant. Instead of creating one table for each rendered query (
timeseries/rolling/key metricsetc.), we generate one intermediate metadata table per metric factory definition (e.g. stars, commits which will later expand downstream totimeseries/rolling/key metricsstars, commits etc.). These are joined downstream onmetrics_v0joining on%+metric+%, since metrics are in the form ofevent_source+metric+suffix.This will finally allow us to set metadata in the metric factory which the frontend will consume easily, for a better UX. Related to #3117.