Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for image signature workflow end to end test #29447

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ricardomaraschini
Copy link
Contributor

@ricardomaraschini ricardomaraschini commented Jan 17, 2025

The following e2e test is flaky in our CI:

[sig-imageregistry][Serial] Image signature workflow can push a signedimage to openshift registry and verify it

After some investigations it seems like what is failing is the build config here

The image build fails with:

STEP 4/8: RUN source /etc/os-release     && rhel_major=${VERSION_ID%.*}     && yum config-manager     --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/baseos/os/"     --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/appstream/os/"
ART yum/dnf wrapper [1]: Checking for CI build pod repo definitions...
ART yum/dnf wrapper [1]: Did not detect that this script is running in a CI build pod. Will not install CI repositories.
error: build error: building at STEP "RUN source /etc/os-release     && rhel_major=${VERSION_ID%.*}     && yum config-manager     --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/baseos/os/"     --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/appstream/os/"": while running runtime: exit status 6

You can see a failure sample here

This PR replaces the base image quay.io/openshift/origin-cli:latest with image-registry.openshift-image-registry.svc:5000/openshift/cli:latest, by replacing the image we can avoid running the yum config-manager command.

the following test is flaky in our e2e:

```
[sig-imageregistry][Serial] Image signature workflow can push a signed
image to openshift registry and verify it
```

after some investigations it seems like what is failing is the build
config
[here](/~https://github.com/openshift/origin/blob/release-4.18/test/extended/testdata/signer-buildconfig.yaml)

the failure is as follow:

```
STEP 4/8: RUN source /etc/os-release     && rhel_major=${VERSION_ID%.*}     && yum config-manager     --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/baseos/os/"     --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/appstream/os/"
ART yum/dnf wrapper [1]: Checking for CI build pod repo definitions...
ART yum/dnf wrapper [1]: Did not detect that this script is running in a CI build pod. Will not install CI repositories.
error: build error: building at STEP "RUN source /etc/os-release     && rhel_major=${VERSION_ID%.*}     && yum config-manager     --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/baseos/os/"     --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/appstream/os/"": while running runtime: exit status 6
```

this build config creates an image containing the following binaries:

- oc
- skopeo
- gpg2

with this pr we are now using the image-registry.openshift-image-registry.svc:5000/openshift/cli:latest
as base image instead of quay.io/openshift/origin-cli:latest.
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@ricardomaraschini
Copy link
Contributor Author

/test all

@xueqzhan
Copy link
Contributor

/lgtm

@ricardomaraschini feel free to apply acknowledge-critical-fixes-only when you are ready.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ricardomaraschini, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@xueqzhan
Copy link
Contributor

/override ci/prow/e2e-aws-ovn-serial

override due to known issue

Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@xueqzhan: Overrode contexts on behalf of xueqzhan: ci/prow/e2e-aws-ovn-serial

In response to this:

/override ci/prow/e2e-aws-ovn-serial

override due to known issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@ricardomaraschini: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 858092d link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn 858092d link false /test e2e-metal-ipi-ovn
ci/prow/e2e-agnostic-ovn-cmd 858092d link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node-upgrade 858092d link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-csi 858092d link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-single-node-serial 858092d link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants