-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for image signature workflow end to end test #29447
base: master
Are you sure you want to change the base?
fix for image signature workflow end to end test #29447
Conversation
the following test is flaky in our e2e: ``` [sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it ``` after some investigations it seems like what is failing is the build config [here](/~https://github.com/openshift/origin/blob/release-4.18/test/extended/testdata/signer-buildconfig.yaml) the failure is as follow: ``` STEP 4/8: RUN source /etc/os-release && rhel_major=${VERSION_ID%.*} && yum config-manager --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/baseos/os/" --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/appstream/os/" ART yum/dnf wrapper [1]: Checking for CI build pod repo definitions... ART yum/dnf wrapper [1]: Did not detect that this script is running in a CI build pod. Will not install CI repositories. error: build error: building at STEP "RUN source /etc/os-release && rhel_major=${VERSION_ID%.*} && yum config-manager --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/baseos/os/" --add-repo "https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi${rhel_major}/${rhel_major}/\$basearch/appstream/os/"": while running runtime: exit status 6 ``` this build config creates an image containing the following binaries: - oc - skopeo - gpg2 with this pr we are now using the image-registry.openshift-image-registry.svc:5000/openshift/cli:latest as base image instead of quay.io/openshift/origin-cli:latest.
Skipping CI for Draft Pull Request. |
/test all |
/lgtm @ricardomaraschini feel free to apply acknowledge-critical-fixes-only when you are ready. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ricardomaraschini, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e-aws-ovn-serial override due to known issue |
@xueqzhan: Overrode contexts on behalf of xueqzhan: ci/prow/e2e-aws-ovn-serial In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ricardomaraschini: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The following e2e test is flaky in our CI:
After some investigations it seems like what is failing is the build config here
The image build fails with:
You can see a failure sample here
This PR replaces the base image
quay.io/openshift/origin-cli:latest
withimage-registry.openshift-image-registry.svc:5000/openshift/cli:latest
, by replacing the image we can avoid running theyum config-manager
command.