Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-2040: CLI command to display bound pvc filesystem usage percentage #1854

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

STOR-2040: CLI command to display bound pvc filesystem usage percentage #1854

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ee69f12
STOR-2040: CLI command to display bound pvc filesystem usage percentage
gmeghnag Aug 22, 2024
51073ae
Merge branch 'openshift:master' into STOR-2040
gmeghnag Oct 24, 2024
a3cf814
fallback to "localhost-recovery-client-token" token
gmeghnag Oct 27, 2024
6027c8b
Merge branch 'openshift:master' into STOR-2040
gmeghnag Nov 6, 2024
2a0cace
OCPBUGS-44011: display output as per the num of pvc counts
gmeghnag Nov 6, 2024
bf39f7d
code improvement
gmeghnag Nov 21, 2024
4149a8a
Merge branch 'openshift:master' into STOR-2040
gmeghnag Nov 21, 2024
f3eebfa
Merge branch 'STOR-2040' of /~https://github.com/gmeghnag/oc into STOR-…
gmeghnag Nov 21, 2024
64325f9
add OWNERS, and minor changes
gmeghnag Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/cli/admin/top/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg/cli/admin/top command exists and it is maintained by workloads team. What about moving this command to pkg/cli/admin/toppvc, etc. and have dedicated OWNERS?.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also better to have an alias like this /~https://github.com/openshift/oc/blob/master/pkg/cli/admin/inspectalerts/OWNERS and

oc/OWNERS_ALIASES

Line 9 in e005223

monitoring-approvers:

# This file just uses aliases defined in OWNERS_ALIASES.

reviewers:
- gmeghnag
- ardaguclu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to add approvers and reviewers from which team will maintain this. I'd prefer not to be in here.

approvers:
- ardaguclu
22 changes: 11 additions & 11 deletions pkg/cli/admin/top/persistentvolumeclaims.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,15 +137,15 @@ func (o *options) Complete(f kcmdutil.Factory, cmd *cobra.Command, args []string
}

type persistentVolumeClaimInfo struct {
Namespace string
Name string
UsagePercentage string
namespace string
name string
usagePercentage string
}

func (v persistentVolumeClaimInfo) PrintLine(out io.Writer) {
gmeghnag marked this conversation as resolved.
Show resolved Hide resolved
printValue(out, v.Namespace)
printValue(out, v.Name)
printValue(out, v.UsagePercentage)
printValue(out, v.namespace)
printValue(out, v.name)
printValue(out, v.usagePercentage)
}

func (o *options) Run(ctx context.Context, args []string) error {
Expand Down Expand Up @@ -211,13 +211,13 @@ func (o *options) Run(ctx context.Context, args []string) error {
valueFloatLong, _ := strconv.ParseFloat(usagePercentage.(string), 64)
valueFloat := fmt.Sprintf("%.2f", valueFloatLong)
if len(pvcInfos) > 0 {
if !(namespaceName == pvcInfos[len(pvcInfos)-1].Namespace && pvcName == pvcInfos[len(pvcInfos)-1].Name) {
pvcInfos = append(pvcInfos, persistentVolumeClaimInfo{Namespace: namespaceName, Name: pvcName, UsagePercentage: valueFloat})
infos = append(infos, persistentVolumeClaimInfo{Namespace: namespaceName, Name: pvcName, UsagePercentage: valueFloat})
if !(namespaceName == pvcInfos[len(pvcInfos)-1].namespace && pvcName == pvcInfos[len(pvcInfos)-1].name) {
pvcInfos = append(pvcInfos, persistentVolumeClaimInfo{namespace: namespaceName, name: pvcName, usagePercentage: valueFloat})
infos = append(infos, persistentVolumeClaimInfo{namespace: namespaceName, name: pvcName, usagePercentage: valueFloat})
}
} else {
pvcInfos = append(pvcInfos, persistentVolumeClaimInfo{Namespace: namespaceName, Name: pvcName, UsagePercentage: valueFloat})
infos = append(infos, persistentVolumeClaimInfo{Namespace: namespaceName, Name: pvcName, UsagePercentage: valueFloat})
pvcInfos = append(pvcInfos, persistentVolumeClaimInfo{namespace: namespaceName, name: pvcName, usagePercentage: valueFloat})
infos = append(infos, persistentVolumeClaimInfo{namespace: namespaceName, name: pvcName, usagePercentage: valueFloat})
}
}

Expand Down